Bugzilla Reviewers, By File
Table of Contents
- About This Page
- Changes That Touch More Than One File
- Areas of Expertise
- CGIs
- Non-CGI (.pl) Scripts
- Libraries (.pm files)
- Templates
- Documentation
- List Of All Reviewers
- Become a Reviewer!
- The Maintainer of This Page
- A Note to Core Bugzilla Developers
About This Page
This is a list of who to ask for review, depending on which files you are changing. These people are essentially the "owners" of these files.
If a file lists more than one reviewer, you can pick any one.
You may ask any reviewer to review any change to any file, but they may defer it to another reviewer if they do not feel qualified. They will probably defer it to the reviewer on this list.
Changes That Touch More Than One File
If your change touches many files, try to pick the file that's at the "heart" of the changes, and ask that person for review. If you can't figure out who to ask for review, each section has a list of "general" reviewers for that area of Bugzilla. Just pick one of them.
These Emails Are For Bugzilla Only
Note: The emails listed on this page are intended for use in Bugzilla. Emails sent to these addresses may not be answered because in many cases, private emails do not help others.
Areas of Expertise
Some reviewers have areas of expertise that are not related to any specific part of Bugzilla. If you would like a review about one of these areas, ask these reviewers.
| Area | Reviewer(s) |
|---|---|
| Code Style | mkanat@bugzilla.org |
| CSS | bugzilla@glob.com.au, mkanat@bugzilla.org |
| JavaScript | |
| Group Security | bugreport@peshkin.net |
| English Language | mkanat@bugzilla.org |
| Windows-Specific Issues | bugzilla@glob.com.au |
| SQL | bugreport@peshkin.net |
| PostgreSQL | mkanat@bugzilla.org |
| User Interface |
CGIs
If there is no person listed for a particular file, then there is no currently assigned reviewer for that file.
The following reviewers are currently available to do reviews on any CGI file, and are likely to actually respond to your review request:
- LpSolit@gmail.com
- mkanat@bugzilla.org
- wurblzap@gmail.com
Pick one of the above reviewers if there is no reviewer listed for a particular file.
Admin CGIs
| File | Reviewer(s) |
|---|---|
| editclassifications.cgi | LpSolit@gmail.com |
| editcomponents.cgi | |
| editfields.cgi | LpSolit@gmail.com, mkanat@bugzilla.org |
| editflagtypes.cgi | LpSolit@gmail.com |
| editgroups.cgi | bugreport@peshkin.net |
| editkeywords.cgi | |
| editmilestones.cgi | |
| editparams.cgi | LpSolit@gmail.com |
| editproducts.cgi | LpSolit@gmail.com |
| editsettings.cgi | mkanat@bugzilla.org |
| editusers.cgi | wurblzap@gmail.com |
| editvalues.cgi | mkanat@bugzilla.org |
| editversions.cgi | |
| editwhines.cgi | wicked@sci.fi |
General CGIs
| File | Reviewer(s) |
|---|---|
| attachment.cgi | LpSolit@gmail.com |
| request.cgi | LpSolit@gmail.com |
| buglist.cgi | wicked@sci.fi, mkanat@bugzilla.org |
| chart.cgi | wicked@sci.fi, gerv@mozilla.org |
| createaccount.cgi | |
| colchange.cgi | |
| config.cgi | |
| describecomponents.cgi | LpSolit@gmail.com |
| describekeywords.cgi | kevin.benton@amd.com, wicked@sci.fi |
| duplicates.cgi | gerv@mozilla.org |
| enter_bug.cgi | LpSolit@gmail.com (OS Detection: timeless@bemail.org) |
| index.cgi | |
| long_list.cgi | Dead file |
| page.cgi | gerv@mozilla.org |
| post_bug.cgi | LpSolit@gmail.com |
| process_bug.cgi | LpSolit@gmail.com |
| query.cgi | bugreport@peshkin.net |
| quips.cgi | wicked@sci.fi |
| relogin.cgi | |
| report.cgi | gerv@mozilla.org |
| reports.cgi | gerv@mozilla.org |
| sanitycheck.cgi | |
| show_activity.cgi | |
| showattachment.cgi | Dead file |
| show_bug.cgi | mkanat@bugzilla.org |
| showdependencygraph.cgi | justdave@bugzilla.org |
| showdependencytree.cgi | |
| sidebar.cgi | |
| summarize_time.cgi | LpSolit@gmail.com |
| testagent.cgi | bugreport@peshkin.net |
| token.cgi | LpSolit@gmail.com |
| userprefs.cgi | wicked@sci.fi |
| votes.cgi | LpSolit@gmail.com |
| xml.cgi | Dead file |
Non-CGI (.pl) Scripts
The generally available reviewers for non-CGI scripts are the same as those for CGI scripts, with the addition of:
- mkanat@bugzilla.org
The Test Suite
The test suite consists of runtests.pl, runtests.sh, and all the files in the t/ directory.
Reviewers for the test suite are:
- gerv@mozilla.org
Other Scripts
| File | Reviewer(s) |
|---|---|
| checksetup.pl | mkanat@bugzilla.org |
| collectstats.pl | gerv@mozilla.org |
| email_in.pl | mkanat@bugzilla.org |
| importxml.pl | LpSolit@gmail.com, ghendricks@novell.com |
| testserver.pl | bugreport@peshkin.net, bugzilla@glob.com.au |
| whineatnews.pl | wicked@sci.fi |
| whine.pl | wicked@sci.fi |
Libraries (.pm files)
These are the files in the Bugzilla/ directory.
The following reviewers are currently available to do reviews on any library, and are likely to actually respond to your review request:
- mkanat@bugzilla.org
Authentication (Bugzilla::Auth)
| File | Reviewer(s) |
|---|---|
| Auth.pm | mkanat@bugzilla.org |
| Bugzilla/Auth/* | mkanat@bugzilla.org |
Database (Bugzilla::DB)
| File | Reviewer(s) |
|---|---|
| DB.pm | mkanat@bugzilla.org |
| Bugzilla/DB/* (except Schema.pm) | mkanat@bugzilla.org |
| Bugzilla/DB/Schema* | mkanat@bugzilla.org |
Template (Bugzilla::Template)
Note, this is for the Bugzilla::Template library, not for templates in general.
| File | Reviewer(s) |
|---|---|
| Template.pm | |
| Bugzilla/Template/Plugin/Bugzilla.pm | kevin.benton@amd.com |
| Bugzilla/Template/Plugin/Hook.pm | |
| Bugzilla/Template/Plugin/User.pm | bugreport@peshkin.net |
General Libraries
| File | Reviewer(s) |
|---|---|
| Attachment.pm | LpSolit@gmail.com |
| BugMail.pm | bugzilla-mozilla@bkor.dhs.org, wicked@sci.fi, gerv@mozilla.org |
| Bug.pm | mkanat@bugzilla.org |
| Bugzilla.pm | mkanat@bugzilla.org |
| CGI.pm | bugzilla@glob.com.au |
| Chart.pm | wicked@sci.fi, gerv@mozilla.org |
| Classification.pm | mkanat@bugzilla.org, LpSolit@gmail.com |
| Component.pm | mkanat@bugzilla.org, LpSolit@gmail.com |
| Config.pm | |
| Config/*.pm | LpSolit@gmail.com |
| Constants.pm | kevin.benton@amd.com |
| Error.pm | kevin.benton@amd.com |
| Field.pm | LpSolit@gmail.com |
| Flag.pm | LpSolit@gmail.com |
| FlagType.pm | LpSolit@gmail.com |
| Group.pm | bugreport@peshkin.net |
| Hook.pm | |
| Install.pm | mkanat@bugzilla.org |
| Keyword.pm | mkanat@bugzilla.org |
| Mailer.pm | mkanat@bugzilla.org, wicked@sci.fi |
| Milestone.pm | mkanat@bugzilla.org, LpSolit@gmail.com |
| Object.pm | mkanat@bugzilla.org |
| Product.pm | mkanat@bugzilla.org, LpSolit@gmail.com |
| Search.pm | bugreport@peshkin.net, justdave@bugzilla.org |
| Series.pm | wicked@sci.fi, gerv@mozilla.org |
| Token.pm | LpSolit@gmail.com |
| Update.pm | LpSolit@gmail.com |
| User.pm | mkanat@bugzilla.org |
| User/Setting.pm | mkanat@bugzilla.org |
| Util.pm | mkanat@bugzilla.org, wurblzap@gmail.com |
| Version.pm | mkanat@bugzilla.org, LpSolit@gmail.com |
| WebService.pm | wurblzap@gmail.com, mkanat@bugzilla.org |
Templates
In general, templates are reviewed by the same people who own the associated CGIs. However, certain reviewers have extra skill with templates/User-Interface, and should be consulted when your changes are only to templates:
- bugzilla-mozilla@bkor.dhs.org
- gerv@mozilla.org
Documentation
For reviews on documentation, make sure that you request them from documentation@bugzilla.bugs.
List Of All Reviewers
The following is a list of all people currently authorized to approve/deny review on patches. Some are component owners, others just like to help out.
All changes to this list must be approved by Dave Miller.
In general, instead of picking a random person from this list to review your patch, you should instead find the appropriate section on this page for the file you are modifying, and ask the appropriate person for review.
| Name | Bugzilla User ID |
|---|---|
| Kevin Benton | kevin.benton@amd.com |
| Frédéric Buclin | LpSolit@gmail.com |
| Vlad Dascalu | vladd@bugzilla.org |
| Gregary Hendricks | ghendricks@novell.com |
| Byron Jones | bugzilla@glob.com.au |
| Max Kanat-Alexander | mkanat@bugzilla.org |
| Teemu Mannermaa | wicked@sci.fi |
| Gervase Markham | gerv@mozilla.org |
| Dave Miller | justdave@bugzilla.org |
| Colin Ogilvie (Documentation Only) | colin.ogilvie@gmail.com |
| Joel Peshkin | bugreport@peshkin.net |
| Marc Schumann | wurblzap@gmail.com |
| Olav Vitters | bugzilla-mozilla@bkor.dhs.org |
The following list is people who are currently on "probationary" reviewer status. This means they are on track to become full reviewers soon and we want to get a feel for how they do reviews and let them get some practice before giving them full rights. Please request reviews from these people so they get practice! People on this list will require someone from the above list to validate their review.
| Name | Bugzilla User ID |
|---|---|
| Dave Lawrence | dkl@redhat.com |
| Reed Loden | reed@reedloden.com |
| Josh Soref | timeless@bemail.org |
Become a Reviewer!
Think you'd make a good reviewer? With the rapidly-growing Bugzilla community, we're increasingly needing good reviewers. We generally require that you've submitted some patches of your own so that we can tell you know what you're doing. If you are interested, contact Dave Miller, Bugzilla Project Manager, and let him know you'd like to help out. If Dave agrees that you're ready to become a reviewer, you will be added to this page. You may be asked to spend some more time developing and submitting patches, so we can get to know you better first.
Updates to This Page
mkanat@bugzilla.org is the author of this page. If you would like to be added or removed from any of the areas listed on this page, please contact Max and he would be glad to help you out, or (assuming you are already a reviewer, of course) make the change to the top part of this page yourself if you have CVS access to the website. If you are interested in being added to this list, see the section Become a Reviewer above.
Note to Core Bugzilla Developers
The lists of suggested reviewers for a particular area or file are merely suggestions. If you know that another developer would be more suited for a particular review or has more time, feel free to ask another person than those listed for each file, provided that the reviewer appears on the List of All Reviewers